Re: [PATCH v3 5/5] gitlab-ci: add whitespace error check

From: Justin Tobler <jltobler@gmail.com>
Date: May 6, 2024, 19:21 UTC
Message-ID: <xjp247ji6zjyacniodws6jbdms7tr7726h6spsn7jvx3axqd4a@k6xhzf4v5akc>
In-Reply-To: <xmqqle4mzwp8.fsf@gitster.g>

On 24/05/06 10:17AM, Junio C Hamano wrote:

Show 15 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
> 
> >> +check-whitespace:
> >> +  image: ubuntu:latest
> >> +  before_script:
> >> +    - ./ci/install-dependencies.sh
> >
> > Do we actually need to install dependencies? I imagine all that's needed
> > would be Git.
> >
> > Other than this question the patch series looks good to me, thanks!
> 
> I am a bit puzzled.  Is the proposal to check our sources with a
> pre-built Git (which by definition would be a bit older than what is
> being tested)?

The GitLab `check-whitespace` CI job only needs Git to run and uses `ci/install-dependencies.sh` to download a pre-built Git package via `apt-get` since `ubuntu:latest` is the container image used. The `ci/install-dependencies.sh` script also fetches a bunch of other dependencies which are not needed.

I think Patrick is proposing, to further simplify, we avoid using `ci/install-dependencies.sh` and only fetch Git. Patrick please correct me if I misunderstand :)

-Justin