Re: [PATCH 2/2] gitlab-ci: add whitespace error check

From: James Liu <james@jamesliu.io>
Date: Apr 30, 2024, 01:59 UTC
Message-ID: <D0X33QRECNTC.33V5ZK9NYIE1F@jamesliu.io>
In-Reply-To: <20240430003323.6210-3-jltobler@gmail.com>

Thanks for putting this together, Justin!

> +check-whitespace:
> +  image: ubuntu:latest

I wonder if we should pin to `ubuntu:22.04` and only update this for each LTS release. It seems like we've done this for the `static-analysis` job above.

Show 13 quoted lines

> +  before_script:
> +    - ./ci/install-docker-dependencies.sh
> +  script:
> +    - ./ci/check-whitespace.sh $CI_MERGE_REQUEST_TARGET_BRANCH_SHA
> +  rules:
> +    - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
> diff --git a/ci/check-whitespace.sh b/ci/check-whitespace.sh
> new file mode 100755
> index 0000000000..1cad2d7374
> --- /dev/null
> +++ b/ci/check-whitespace.sh
> @@ -0,0 +1,16 @@
> +#! /bin/sh

nit: there seems to be extra whitespace after the shebang :D

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.