Re: [PATCH v3 5/5] gitlab-ci: add whitespace error check

From: Justin Tobler <jltobler@gmail.com>
Date: May 7, 2024, 18:06 UTC
Message-ID: <lkd7hxcwnepjgyjhz5nl46h2igve2ttdoajtjgnene56qau6gh@dec6ticwjfqu>
In-Reply-To: <ZjmqEEB2gXU_nKHz@tanuki>

On 24/05/07 06:12AM, Patrick Steinhardt wrote:

> I just wondered how GitHub Workflows manages without installing any
> dependencies at all. Is Git already part of the default images? If so,
> there is no need to install anything and we can just execute the script
> directly, which saves some time.

Git is not bundled by default in the "ubuntu:latest" container image. We would have to install it ourselves. As for why GitHub Workflows do not have to install Git, it looks like each runner has a defined set of included software which happens to include Git.

https://github.com/actions/runner-images/blob/ubuntu22/20240422.1/images/ubuntu/Ubuntu2204-Readme.md

> If there is a need to install Git we could either just manually install
> it in the `before_script` or leave it as-is. I don't mind it much either
> way.

I don't have strong opinions, but I think I would prefer to leave it as-is and reuse `ci/install-dependencies.sh`. I'll forgo sending another version unless there is addional feedback. Thanks

-Justin