Re: [PATCH v4 05/12] builtin: add new "history" command
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 22, 2025, 03:32 UTC
- Message-ID
- <xmqqldl31uhq.fsf@gitster.g>
- In-Reply-To
- <CAOLa=ZQSc0jHv9gK5T06GA_mprknucwCj5H_M2djZ-UWfRMbJQ@mail.gmail.com>
Karthik Nayak <karthik.188@gmail.com> writes:
Show 12 quoted lines
>> + const char * const usage[] = {
>> + N_("git history [<options>]"),
>> + NULL,
>> + };
>
> Nit: We have pointer alignment set to 'Right' in our styling guide and
> also mentioned in our 'Documentation/CodingGuidelines'
>
> When declaring pointers, the star sides with the variable
> name, i.e. "char *string", not "char* string" or
> "char * string". This makes it easier to understand code
> like "char *string, c;".But there is nothing specified for an asterisk that cannot side with variable name, like the one we see above. I _think_ the "space on both sides" is the prevalent style, but I do not know (although I suspect you do---as the person with most changes in it) what (y)our clang format configuration wants to do. Can you make sure the tool suggests the style that matches the prevailing style?
Thanks.