Re: [PATCH RFC v2 10/16] add-patch: split out header from "add-interactive.h"

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 25, 2025, 16:41 UTC
Message-ID: <xmqqfrdfs69y.fsf@gitster.g>
In-Reply-To: <20250824-b4-pks-history-builtin-v2-10-964ac12f65bd@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 14 quoted lines

> While we have a "add-patch.c" code file, its declarations are part of
> "add-interactive.h". This makes it somewhat harder than necessary to
> find relevant code and to identify clear boundaries between the two
> subsystems.
>
> Split up concerns and move declarations that relate to "add-patch.c"
> into a new "add-patch.h" header.
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
> ---
>  add-interactive.h | 23 +++--------------------
>  add-patch.c       |  1 +
>  add-patch.h       | 26 ++++++++++++++++++++++++++
>  3 files changed, 30 insertions(+), 20 deletions(-)

What is left in the interactive side is the things "add -i" can do other than "add -p" (aka "add -i" plus "5: patch"), which makes sense.

It is surprising that this step does not touch any of the clients of the "-p" machinery (like "git reset -p"), though. They surely do not need the rest of "add-interactive.h", do they?