Re: [PATCH RFC v2 12/16] add-patch: remove dependency on "add-interactive" subsystem
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 25, 2025, 16:43 UTC
- Message-ID
- <xmqqa53ns66a.fsf@gitster.g>
- In-Reply-To
- <20250824-b4-pks-history-builtin-v2-12-964ac12f65bd@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 13 quoted lines
> With the preceding commit we have split out interactive configuration > that is used by both "git add -p" and "git add -i". But we still > initialize that configuration in the "add -p" subsystem by calling > `init_add_i_state()`, even though we only do so to initialize the > interactive configuration as well as a repository pointer. > > Stop doing so and instead store and initialize the interactive > configuration in `struct add_p_state` directly. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > add-patch.c | 68 ++++++++++++++++++++++++++++++++----------------------------- > 1 file changed, 36 insertions(+), 32 deletions(-)
Ahh, with the two steps, this and the previous one, my question is answered. I like the shape of the code base at this step very much.