Re: [PATCH RFC v3 01/18] sequencer: optionally skip printing commit summary

From: Patrick Steinhardt <ps@pks.im>
Date: Sep 15, 2025, 09:32 UTC
Message-ID: <aMfdJZgERk9Hbjlq@pks.im>
In-Reply-To: <fcb3355d-c9df-408a-9e28-421a7a18e1fd@gmail.com>

On Wed, Sep 10, 2025 at 03:01:54PM +0100, Phillip Wood wrote:

Show 14 quoted lines

> On 04/09/2025 15:27, Patrick Steinhardt wrote:
> > diff --git a/sequencer.c b/sequencer.c
> > index aaf2e4df64..7066cdc939 100644
> > --- a/sequencer.c
> > +++ b/sequencer.c
> > @@ -1742,7 +1742,7 @@ static int do_commit(struct repository *r,
> >   			refs_delete_ref(get_main_ref_store(r), "",
> >   					"CHERRY_PICK_HEAD", NULL, REF_NO_DEREF);
> >   			unlink(git_path_merge_msg(r));
> > -			if (!is_rebase_i(opts))
> > +			if (!is_rebase_i(opts) && !opts->skip_commit_summary)
> 
> I think it would be cleaner to make rebase set the new option and remove
> !is_rebase_i(opts) here.

Good suggestion, will do.

Patrick

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.