Re: [PATCH v4 08/12] add-patch: split out `struct interactive_options`

From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Oct 2, 2025, 09:25 UTC
Message-ID: <e816989d-bb45-4696-bd2e-b1ac6c3fa312@app.fastmail.com>
In-Reply-To: <20251001-b4-pks-history-builtin-v4-8-8e61ddb86317@pks.im>

On Wed, Oct 1, 2025, at 17:57, Patrick Steinhardt wrote:

> The `struct add_p_opt` is reused both by our the infra for "git add -p"

“both by our the infra”

I think an edit to this sentence got mixed up/jumbled with the old version.

> and "git add -i". Users of `run_add_i()` for example are expected to
> pass `struct add_p_opt`. This is somewhat confusing and raises the
> question which options apply to what part of the stack.

s/question which/question of which/ ?

Or: s/question which options apply to what/question of what options apply to what/

>
>[snip]

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.