Re: [PATCH v2 03/12] ci: allow skipping sudo on dockerized jobs

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 10, 2024, 17:21 UTC
Message-ID: <xmqqjzl5uo9f.fsf@gitster.g>
In-Reply-To: <874jc9kvls.fsf@to1.studio>

Toon claes <toon@iotcl.com> writes:

Show 6 quoted lines

>> [PATCH v2 03/12] ci: allow skipping sudo on dockerized jobs
>
> I think this title is somewhat misleading. While it's true, I don't
> think it's limited to dockerized jobs. Something more along the lines of
> "allow running install-dependencies.sh as root" would make more sense to
> me.

It is true that dockerized is not the essential part of this change; and it is that we skip sudo when we are already root. So I agree with you that the original title is misleading.

"allow running as root" is somehow a bit unsatisfactory, though. It sounds as if _we_ were not allowing it before---what was preventing us from doing so was a system without sudo.

Stepping back a bit, I wonder if install-dependencies.sh will stay to be the only one among ci/ scripts that need to run things as root. If we moved the new logic in this patch to ci/lib.sh that is included by everybody, then the title of the patch can become a short and sweet

    ci: skip sudo when we are already root

> That's the only tiny remark I have on this patch series.

Thanks.