Re: [PATCH v2 12/12] t0612: add tests to exercise Git/JGit reftable compatibility
- From
Justin Tobler <jltobler@gmail.com>
- Date
- Apr 10, 2024, 20:43 UTC
- Message-ID
- <t4powjtw4yapbivatafkez5e2ha5gcssintxam47ibkvjlb4le@ob5deeaxpzqr>
- In-Reply-To
- <160b026e69547739a526fb6276a895904a4d33a8.1712555682.git.ps@pks.im>
On 24/04/08 08:47AM, Patrick Steinhardt wrote:
Show 38 quoted lines
> While the reftable format is a recent introduction in Git, JGit already > knows to read and write reftables since 2017. Given the complexity of > the format there is a very real risk of incompatibilities between those > two implementations, which is something that we really want to avoid. > > Add some basic tests that verify that reftables written by Git and JGit > can be read by the respective other implementation. For now this test > suite is rather small, only covering basic functionality. But it serves > as a good starting point and can be extended over time. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > t/t0612-reftable-jgit-compatibility.sh | 132 +++++++++++++++++++++++++ > 1 file changed, 132 insertions(+) > create mode 100755 t/t0612-reftable-jgit-compatibility.sh > > diff --git a/t/t0612-reftable-jgit-compatibility.sh b/t/t0612-reftable-jgit-compatibility.sh > new file mode 100755 > index 0000000000..222464e360 > --- /dev/null > +++ b/t/t0612-reftable-jgit-compatibility.sh > @@ -0,0 +1,132 @@ > +#!/bin/sh > + > +test_description='reftables are compatible with JGit' > + > +GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main > +export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME > +GIT_TEST_DEFAULT_REF_FORMAT=reftable > +export GIT_TEST_DEFAULT_REF_FORMAT > + > +# JGit does not support the 'link' DIRC extension. > +GIT_TEST_SPLIT_INDEX=0 > +export GIT_TEST_SPLIT_INDEX > + > +. ./test-lib.sh > + > +if ! test_have_prereq JGIT
Do we want these tests to run in CI? As far as I can tell these tests would always be skipped.
-Justin
> +then > + skip_all='skipping reftable JGit tests' > + test_done > +fi
...