[PATCH 2/2] t0610: execute git-pack-refs(1) with specified umask
- From
Patrick Steinhardt <ps@pks.im>
- Date
- Apr 9, 2024, 09:57 UTC
- Message-ID
- <a3bfea94365138e85cac473a83eb51e821dd0def.1712656576.git.ps@pks.im>
- In-Reply-To
- <cover.1712656576.git.ps@pks.im>
The tests for git-pack-refs(1) with the `core.sharedRepository` config execute git-pack-refs(1) outside of the shell that has the expected umask set. This is wrong because we want to test the behaviour of that command with different umasks. The issue went unnoticed because most distributions have a default umask of 0022, and we only ever test with `--shared=true`, which re-adds the group write bit.
Fix the issue by moving git-pack-refs(1) into the umask'd shell and add a bunch of test cases that exercise behaviour more thoroughly.
Note that we drop the check for whether `core.sharedRepository` was set to the correct value to make the test setup a bit easier. We should be able to rely on git-init(1) doing its thing correctly. Furthermore, to help readability, we convert tests that pass `--shared=true` to instead pass the equivalent `--shared=group`.
Signed-off-by: Patrick Steinhardt <ps@pks.im> --- t/t0610-reftable-basics.sh | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-)
diff --git a/t/t0610-reftable-basics.sh b/t/t0610-reftable-basics.sh index a3269c20e0..8ffecefadc 100755 --- a/t/t0610-reftable-basics.sh +++ b/t/t0610-reftable-basics.sh @@ -105,8 +105,7 @@ test_expect_reftable_perms () { test_when_finished "rm -rf repo" && ( umask $umask && - git init --shared=$shared repo && - test 1 = "$(git -C repo config core.sharedrepository)" + git init --shared=$shared repo ) && test_expect_perms "$expect" repo/.git/reftable/tables.list && for table in repo/.git/reftable/*.ref @@ -122,9 +121,9 @@ test_expect_reftable_perms () { umask $umask && git init --shared=$shared repo && test_commit -C repo A && - test_line_count = 3 repo/.git/reftable/tables.list + test_line_count = 3 repo/.git/reftable/tables.list && + git -C repo pack-refs ) && - git -C repo pack-refs && test_expect_perms "$expect" repo/.git/reftable/tables.list && for table in repo/.git/reftable/*.ref do @@ -134,8 +133,17 @@ test_expect_reftable_perms () { ' } -test_expect_reftable_perms 002 true "-rw-rw-r--" -test_expect_reftable_perms 022 true "-rw-rw-r--" +test_expect_reftable_perms 002 umask "-rw-rw-r--" +test_expect_reftable_perms 022 umask "-rw-r--r--" +test_expect_reftable_perms 027 umask "-rw-r-----" + +test_expect_reftable_perms 002 group "-rw-rw-r--" +test_expect_reftable_perms 022 group "-rw-rw-r--" +test_expect_reftable_perms 027 group "-rw-rw----" + +test_expect_reftable_perms 002 world "-rw-rw-r--" +test_expect_reftable_perms 022 world "-rw-rw-r--" +test_expect_reftable_perms 027 world "-rw-rw-r--" test_expect_success 'clone: can clone reftable repository' ' test_when_finished "rm -rf repo clone" &&
-- 2.44.GIT