Re: [PATCH v3 07/13] ci: fix setup of custom path for GitLab CI
- From
Eric Sunshine <sunshine@sunshineco.com>
- Date
- Apr 11, 2024, 10:06 UTC
- Message-ID
- <CAPig+cR19_xdKx84xQ+7c4Cp6GzeOeHSit7-ujJJQ6gE=q+f_w@mail.gmail.com>
- In-Reply-To
- <ef61b578da84dbd8087bf22c43029acf6983e547.1712825204.git.ps@pks.im>
On Thu, Apr 11, 2024 at 5:10 AM Patrick Steinhardt <ps@pks.im> wrote:
Show 10 quoted lines
> Part of "install-dependencies.sh" is to install some binaries required > for tests into a custom directory that gets added to the PATH. This > directory is located at "$HOME/path" and thus depends on the current > user that the script executes as. > > This creates problems for GitLab CI, which installs dependencies as the > root user, but runs tests as a separate, unprivileged user. As their > respective home directories are different, we will end up using two > different custom path directories. Consequently, the unprivileged user > will not be able eto find the binaries that were setu up as root user.
s/eto/to/ s/setu/setup/
> Fix this issue by allowing CI to override the custom path, which allows > GitLab to set up a constant value that isn't derived from "$HOME". > ---
Missing sign-off.