Re: [PATCH 08/12] ci: make Perforce binaries executable for all users
- From
Josh Steadmon <steadmon@google.com>
- Date
- Apr 5, 2024, 20:01 UTC
- Message-ID
- <ZhBX7REqotKKHpWg@google.com>
- In-Reply-To
- <22f86f8ccb9f3fb7f98ff57ddd09724fc9e44628.1712235356.git.ps@pks.im>
On 2024.04.04 15:25, Patrick Steinhardt wrote:
Show 27 quoted lines
> The Perforce binaries are only made executable for the current user. On > GitLab CI though we execute tests as a different user than "root", and > thus these binaries may not be executable by that test user. > > Fix the setup so that we set the executable bits for all users. > > Signed-off-by: Patrick Steinhardt <ps@pks.im> > --- > ci/install-dependencies.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > index f4eb125fd2..068c478025 100755 > --- a/ci/install-dependencies.sh > +++ b/ci/install-dependencies.sh > @@ -47,7 +47,7 @@ ubuntu-*) > mkdir --parents "$CUSTOM_PATH" > wget --quiet --directory-prefix="$CUSTOM_PATH" \ > "$P4WHENCE/bin.linux26x86_64/p4d" "$P4WHENCE/bin.linux26x86_64/p4" > - chmod u+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4" > + chmod a+x "$CUSTOM_PATH/p4d" "$CUSTOM_PATH/p4" > > wget --quiet "$LFSWHENCE/git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" > tar -xzf "git-lfs-linux-amd64-$LINUX_GIT_LFS_VERSION.tar.gz" -C "$CUSTOM_PATH" --strip-components=1 "git-lfs-$LINUX_GIT_LFS_VERSION/git-lfs" > -- > 2.44.GIT >
Do we break CI in patch 6 and 7 until we get this fix? Perhaps we should just squash this into patch 6?