Re: [PATCH v4 1/2] pack-bitmap: fix memory leak if load_bitmap() failed

From: Junio C Hamano <gitster@pobox.com>
Date: May 29, 2025, 22:04 UTC
Message-ID: <xmqqjz5zhy4i.fsf@gitster.g>
In-Reply-To: <aDi8OD08I6+6BLja@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 11 quoted lines

> In c11c3b5681 (Documentation/SubmittingPatches: What's Acked-by and
> Tested-by?, 2008-02-03) you added:
>
>     Notice that you can place your own Signed-off-by: line when
>     forwarding somebody else's patch [...]. Indeed you are encouraged
>     to do so.  [...]
>
> and that text survives into the current version of SubmittingPatches.
> So I think that while our documentation encourages people to add their
> own S-o-b to others' patches sent on their behalf, it doesn't
> explicitly require it.

It would not hurt that much if I pretended that I ignored what Lidong forwarded and picked up your patch directly from the list, only because what was forwarded was public. If it were a privately shared patch, sign-off is required, so we'd need to tighten the language in the SubmittingPatches document, I think.

Thanks.