Re: [PATCH v4 1/2] pack-bitmap: fix memory leak if load_bitmap() failed

From: lidongyan <502024330056@smail.nju.edu.cn>
Date: May 30, 2025, 03:50 UTC
Message-ID: <68A128BD-DB63-403F-82DF-B8B6C78D5308@smail.nju.edu.cn>
In-Reply-To: <xmqqjz5zmnxy.fsf@gitster.g>

Got it, I will add my sign-off.

Show 19 quoted lines

> 2025年5月29日 23:33，Junio C Hamano <gitster@pobox.com> 写道：
> 
> "Taylor Blau via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Taylor Blau <me@ttaylorr.com>
>> 
>> After going through the "failed" label, load_bitmap() will return -1,
>> and its caller (either prepare_bitmap_walk() or prepare_bitmap_git())
>> will then call free_bitmap_index().
>> ...
>> The solution is to remove the error handling code in load_bitmap(), because
>> its caller will always call free_bitmap_index() in case of an error.
>> 
>> Signed-off-by: Taylor Blau <me@ttaylorr.com>
>> ---
> 
> As this is Lidong relaying <aCOFqYdnPp1Lne4Y@nand.local> that Taylor
> sent to the list, shouldn't Lidong's sign-off be after Taylor's?
>