Re: [PATCH v5 0/3] pack-bitmap: fix memory leak if load_bitmap failed

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 3, 2025, 22:14 UTC
Message-ID: <aD9z4bVNSLi0TuRq@nand.local>
In-Reply-To: <pull.1962.v5.git.git.1748920444.gitgitgadget@gmail.com>

On Tue, Jun 03, 2025 at 03:14:01AM +0000, Lidong Yan via GitGitGadget wrote:

Show 6 quoted lines

> Lidong Yan (2):
>   pack-bitmap: reword comments in test_bitmap_commits()
>   pack-bitmap: add load corrupt bitmap test
>
> Taylor Blau (1):
>   pack-bitmap: fix memory leak if load_bitmap() failed

This version looks pretty good to me. There's a pair of minor suggestions that I left on the second patch, but otherwise I think the result is ready to start merging down.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.