From: Junio C Hamano Date: Thu, 29 May 2025 22:04:45 GMT Subject: Re: [PATCH v4 1/2] pack-bitmap: fix memory leak if load_bitmap() failed Message-ID: In-Reply-To: Taylor Blau writes: > In c11c3b5681 (Documentation/SubmittingPatches: What's Acked-by and > Tested-by?, 2008-02-03) you added: > > Notice that you can place your own Signed-off-by: line when > forwarding somebody else's patch [...]. Indeed you are encouraged > to do so. [...] > > and that text survives into the current version of SubmittingPatches. > So I think that while our documentation encourages people to add their > own S-o-b to others' patches sent on their behalf, it doesn't > explicitly require it. It would not hurt that much if I pretended that I ignored what Lidong forwarded and picked up your patch directly from the list, only because what was forwarded was public. If it were a privately shared patch, sign-off is required, so we'd need to tighten the language in the SubmittingPatches document, I think. Thanks.