Re: [PATCH v4 2/2] pack-bitmap: add load corrupt bitmap test

From: Taylor Blau <me@ttaylorr.com>
Date: May 29, 2025, 21:21 UTC
Message-ID: <aDjP7GiNvflWepAL@nand.local>
In-Reply-To: <xmqqbjrbmndn.fsf@gitster.g>

On Thu, May 29, 2025 at 08:45:40AM -0700, Junio C Hamano wrote:

Show 11 quoted lines

> > Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
> > ---
> >  pack-bitmap.c           | 73 +++++++++++++++++++++++++++++++++++++----
> >  pack-bitmap.h           |  1 +
> >  t/helper/test-bitmap.c  |  8 +++++
> >  t/t5310-pack-bitmaps.sh | 27 +++++++++++++++
> >  4 files changed, 103 insertions(+), 6 deletions(-)
>
> After the second round of the series, no review comments seem to
> have been sent to the list.  Is everybody happy with the latest
> iteration?

Sorry for missing this one from earlier this week. I left a few comments on the latest round. I think we are getting there, but I do not feel comfortable merging down the series just yet.

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.