git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v7 4/4] checkout: -m (--merge) uses autostash when switching branches

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 9, 2026, 17:55 UTC
Message-ID
<xmqqjyugt3v8.fsf@gitster.g>
In-Reply-To
<1c29e1997132273d58831c470f581fc9ae53198a.1775741265.git.gitgitgadget@gmail.com>
"Harald Nordgren via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 9 quoted lines
>  === 3. Merge conflict
>  
> -When a merge conflict happens during switching branches with
> -the `-m` option, you would see something like this:
> +When the `--merge` (`-m`) option is in effect and the locally
> +modified files overlap with files that need to be updated by the
> +branch switch, the changes are stashed and reapplied after the
> +switch.  If the stash application results in conflicts, they are not
> +resolved and the stash is saved to the stash list:

"results in conflicts, they are not resolved" felt a bit funny thing to say. The definition of resulting in conflicits is to be left with unresolvable conflicts ;-), so ...

    ... and reapplied after the switch.  If this process results in
    conflicts, a stash entry is saved and made available in "git
    stash list".  This is so that you can revisit it in case if you
    fail to resolve conflicts correctly.

or something. But reading what you have further down, I think the last sentence "This is so that ..." is probably unnecessary.

Show 17 quoted lines
> ...
> +Your local changes are stashed, however, applying it to carry
> +forward your local changes resulted in conflicts:
>  
> + - You can try resolving them now.  If you resolved them
> +   successfully, discard the stash entry with "git stash drop".
>  
> + - Alternatively you can "git reset --hard" if you do not want
> +   to deal with them right now, and later "git stash pop" to
> +   recover your local changes.
>  ------------
> +
> +You can try resolving the conflicts now.  Edit the conflicting files
> +and mark them resolved with `git add` as usual, then run `git stash
> +drop` to discard the stash entry.  Alternatively, you can clear the
> +working tree with `git reset --hard` and recover your local changes
> +later with `git stash pop`.
Very well written.  I am very happy to see this text.
Show 18 quoted lines
> diff --git a/Documentation/git-switch.adoc b/Documentation/git-switch.adoc
> index 87707e9265..3147023dc3 100644
> --- a/Documentation/git-switch.adoc
> +++ b/Documentation/git-switch.adoc
> @@ -126,15 +126,16 @@ variable.
>  	If you have local modifications to one or more files that are
>  	different between the current branch and the branch to which
>  	you are switching, the command refuses to switch branches in
> +	order to preserve your modifications in context.  With this
> +	option, the conflicting local changes are automatically
> +	stashed before the switch and reapplied afterwards.  If the
> +	local changes do not overlap with the differences between
> +	branches, the switch proceeds without stashing.  If
> +	reapplying the stash results in conflicts, the entry is
> +	saved to the stash list.  Resolve the conflicts and run
> +	`git stash drop` when done, or clear the working tree
> +	(e.g. with `git reset --hard`) before running `git stash pop`
> +	later to re-apply your changes.
We lost "however" but it is OK.

We would want to hint that "The command refuses to" refers to the default behaviour when option being described ("--merge") is not given by some other means, which was what the "however" we lost from the updated text was trying to do.

Show 8 quoted lines
> @@ -217,15 +218,15 @@ $ git switch mytopic
>  error: You have local changes to 'frotz'; not switching branches.
>  ------------
>  
> -You can give the `-m` flag to the command, which would try a three-way
> -merge:
> +You can give the `-m` flag to the command, which would carry your local
> +changes to the new branch:

Yes, saying "carry your local changes to" is much clearer than "try a three-way merge". I very much like this new text.

Show 10 quoted lines
>  ------------
>  $ git switch -m mytopic
> -Auto-merging frotz
> +Switched to branch 'mytopic'
>  ------------
>  
> -After this three-way merge, the local modifications are _not_
> +After the switch, the local modifications are reapplied and are _not_
>  registered in your index file, so `git diff` would show you what
>  changes you made since the tip of the new branch.

So now to the more exciting part. But there isn't much to comment on, as it stayed the same since a previous iteration where Phillip's excellent "we do not have to waste cycles to dry-run at all" idea.

Show 33 quoted lines
> diff --git a/t/t7201-co.sh b/t/t7201-co.sh
> index 9bcf7c0b40..857a5a6bd1 100755
> --- a/t/t7201-co.sh
> +++ b/t/t7201-co.sh
> @@ -210,6 +210,194 @@ test_expect_success 'checkout --merge --conflict=diff3 <branch>' '
>  	test_cmp expect two
>  '
>  
> +test_expect_success 'checkout --merge --conflict=zdiff3 <branch>' '
> +	git checkout -f main &&
> +	git reset --hard &&
> +	git clean -f &&
> +
> +	fill a b X d e >two &&
> +	git checkout --merge --conflict=zdiff3 simple &&
> +
> +	cat <<-EOF >expect &&
> +	a
> +	<<<<<<< simple
> +	c
> +	||||||| main
> +	b
> +	c
> +	d
> +	=======
> +	b
> +	X
> +	d
> +	>>>>>>> local
> +	e
> +	EOF
> +	test_cmp expect two
> +'

OK. Do we want to verify with "git stash show -p" or something what we stashed away? I see we later have an explicit test to see that the stash entry can actually be used in "stash pop" after clearing the stage with "checkout -f", so perhaps it is OK to leave it to that test, instead of checking in every step.

Show 10 quoted lines
> +test_expect_success 'checkout -m skips stash when no conflict' '
> +	git checkout -f main &&
> +	git clean -f &&
> +
> +	fill 0 x y z >same &&
> +	git checkout -m side >actual 2>&1 &&
> +	test_grep ! "Created autostash" actual &&
> +	fill 0 x y z >expect &&
> +	test_cmp expect same
> +'

This one may not just check "test_grep !" but also check the output of "git stash list", perhaps take one before and after "checkout -m" and compare them?

Show 11 quoted lines
> +test_expect_success 'checkout -m stashes and applies on conflicting changes' '
> +	git checkout -f main &&
> +	git clean -f &&
> +
> +	fill 1 2 3 4 5 6 7 >one &&
> +	git checkout -m side >actual 2>&1 &&
> +	test_grep ! "Created autostash" actual &&
> +	test_grep "Applied autostash" actual &&
> +	fill 1 2 3 4 5 6 7 >expect &&
> +	test_cmp expect one
> +'
Nice.
Show 14 quoted lines
> +test_expect_success 'checkout -m stashes on truly conflicting changes' '
> +	git checkout -f main &&
> +	git clean -f &&
> +
> +	fill 1 2 3 4 5 >one &&
> +	test_must_fail git checkout side 2>stderr &&
> +	test_grep "Your local changes" stderr &&
> +	git checkout -m side >actual 2>&1 &&
> +	test_grep ! "Created autostash" actual &&
> +	test_grep "resulted in conflicts" actual &&
> +	test_grep "git stash drop" actual &&
> +	git stash drop &&
> +	git reset --hard
> +'
OK.  This is an emulation of a user who gives up resolving and punts.
Show 12 quoted lines
> +test_expect_success 'checkout -m produces usable stash on conflict' '
> +	git checkout -f main &&
> +	git clean -f &&
> +
> +	fill 1 2 3 4 5 >one &&
> +	git checkout -m side >actual 2>&1 &&
> +	test_grep "recover your local changes" actual &&
> +	git checkout -f main &&
> +	git stash pop &&
> +	fill 1 2 3 4 5 >expect &&
> +	test_cmp expect one
> +'
Nice.
Show 22 quoted lines
> +test_expect_success 'checkout -m applies stash cleanly with non-overlapping changes in same file' '
> +	git checkout -f main &&
> +	git reset --hard &&
> +	git clean -f &&
> +
> +	git checkout -b nonoverlap_base &&
> +	fill a b c d >file &&
> +	git add file &&
> +	git commit -m "add file" &&
> +
> +	git checkout -b nonoverlap_child &&
> +	fill a b c INSERTED d >file &&
> +	git commit -a -m "insert line near end of file" &&
> +
> +	fill DIRTY a b c INSERTED d >file &&
> +
> +	git checkout -m nonoverlap_base 2>stderr &&
> +	test_grep "Applied autostash" stderr &&
> +	test_grep ! "resulted in conflicts" stderr &&
> +
> +	fill DIRTY a b c d >expect &&
> +	test_cmp expect file &&

Should we or should we not see an extra stack entry saved at this point? Don't we want to test it?

Show 5 quoted lines
> +
> +	git checkout -f main &&
> +	git branch -D nonoverlap_base &&
> +	git branch -D nonoverlap_child
> +'
Overall very nicely done.
Previous: Harald Nordgren via GitGitGadgetNext: Harald Nordgren
Message 45 of 164 in “checkout: add --autostash option for branch switching”
  1. checkout: add --autostash option for branch switchingHarald Nordgren via GitGitGadget, Mar 12, 2026
  2. Junio C HamanoMar 12, 2026
  3. Harald NordgrenMar 12, 2026
  4. Phillip WoodMar 13, 2026
  5. Junio C HamanoMar 14, 2026
  6. Phillip WoodMar 16, 2026
  7. Junio C HamanoMar 16, 2026
  8. Harald NordgrenMar 17, 2026
  9. Harald NordgrenMar 19, 2026
  10. Junio C HamanoMar 19, 2026
  11. Harald NordgrenMar 31, 2026
  12. Harald NordgrenApr 9, 2026
  13. Harald NordgrenApr 9, 2026
  14. Junio C HamanoApr 9, 2026
  15. Harald NordgrenApr 9, 2026
  16. Harald NordgrenApr 9, 2026
  17. checkout: add --autostash option for branch switchingHarald Nordgren via GitGitGadget, Mar 12, 2026
  18. Junio C HamanoMar 12, 2026
  19. Harald NordgrenMar 13, 2026
  20. checkout: add --autostash option for branch switchingHarald Nordgren via GitGitGadget, Mar 13, 2026
  21. Junio C HamanoMar 13, 2026
  22. Harald NordgrenMar 13, 2026
  23. Junio C HamanoMar 13, 2026
  24. checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Mar 14, 2026
  25. Junio C HamanoMar 15, 2026
  26. 0/4 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Mar 15, 2026
  27. 1/4 stash: add --ours-label, --theirs-label, --base-label for applyHarald Nordgren via GitGitGadget, Mar 15, 2026
  28. 2/4 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Mar 15, 2026
  29. 3/4 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Mar 15, 2026
  30. 4/4 checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Mar 15, 2026
  31. 0/4 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Mar 17, 2026
  32. 1/4 stash: add --ours-label, --theirs-label, --base-label for applyHarald Nordgren via GitGitGadget, Mar 17, 2026
  33. 2/4 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Mar 17, 2026
  34. 3/4 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Mar 17, 2026
  35. 4/4 checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Mar 17, 2026
  36. 0/4 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 9, 2026
  37. 1/4 stash: add --ours-label, --theirs-label, --base-label for applyHarald Nordgren via GitGitGadget, Apr 9, 2026
  38. Junio C HamanoApr 9, 2026
  39. Harald NordgrenApr 9, 2026
  40. 2/4 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 9, 2026
  41. 3/4 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 9, 2026
  42. Junio C HamanoApr 9, 2026
  43. Harald NordgrenApr 9, 2026
  44. 4/4 checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 9, 2026
  45. Junio C HamanoApr 9, 2026
  46. Harald NordgrenApr 9, 2026
  47. Junio C HamanoApr 9, 2026
  48. Harald NordgrenApr 9, 2026
  49. 0/4 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 9, 2026
  50. 1/4 stash: add --ours-label, --theirs-label, --base-label for applyHarald Nordgren via GitGitGadget, Apr 9, 2026
  51. Phillip WoodApr 10, 2026
  52. Junio C HamanoApr 10, 2026
  53. Harald NordgrenApr 10, 2026
  54. 2/4 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 9, 2026
  55. Phillip WoodApr 10, 2026
  56. Junio C HamanoApr 10, 2026
  57. Harald NordgrenApr 10, 2026
  58. 3/4 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 9, 2026
  59. Phillip WoodApr 10, 2026
  60. Junio C HamanoApr 10, 2026
  61. Harald NordgrenApr 10, 2026
  62. 4/4 checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 9, 2026
  63. Chris TorekApr 9, 2026
  64. Harald NordgrenApr 10, 2026
  65. 0/4 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 10, 2026
  66. 1/4 stash: add --label-ours, --label-theirs, --label-base for applyHarald Nordgren via GitGitGadget, Apr 10, 2026
  67. 3/4 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 10, 2026
  68. 4/4 checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 10, 2026
  69. Jeff KingApr 11, 2026
  70. Harald NordgrenApr 11, 2026
  71. Jeff KingApr 11, 2026
  72. Jeff KingApr 11, 2026
  73. 2/4 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 10, 2026
  74. Junio C HamanoApr 10, 2026
  75. 0/4 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 12, 2026
  76. 1/4 stash: add --label-ours, --label-theirs, --label-base for applyHarald Nordgren via GitGitGadget, Apr 12, 2026
  77. 2/4 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 12, 2026
  78. 3/4 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 12, 2026
  79. 4/4 checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 12, 2026
  80. Jeff KingApr 12, 2026
  81. Junio C HamanoApr 13, 2026
  82. Harald NordgrenApr 14, 2026
  83. Junio C HamanoApr 14, 2026
  84. Junio C HamanoApr 14, 2026
  85. Junio C HamanoApr 14, 2026
  86. 0/4 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 14, 2026
  87. 1/4 stash: add --label-ours, --label-theirs, --label-base for applyHarald Nordgren via GitGitGadget, Apr 14, 2026
  88. 2/4 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 14, 2026
  89. 3/4 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 14, 2026
  90. 4/4 checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 14, 2026
  91. 0/4 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 14, 2026
  92. 1/4 stash: add --label-ours, --label-theirs, --label-base for applyHarald Nordgren via GitGitGadget, Apr 14, 2026
  93. Phillip WoodApr 14, 2026
  94. Junio C HamanoApr 14, 2026
  95. Harald NordgrenApr 14, 2026
  96. Harald NordgrenApr 14, 2026
  97. Phillip WoodApr 15, 2026
  98. Harald NordgrenApr 15, 2026
  99. 2/4 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 14, 2026
  100. Phillip WoodApr 14, 2026
  101. Harald NordgrenApr 14, 2026
  102. 3/4 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 14, 2026
  103. Phillip WoodApr 14, 2026
  104. Harald NordgrenApr 14, 2026
  105. 4/4 checkout: -m (--merge) uses autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 14, 2026
  106. Phillip WoodApr 14, 2026
  107. Junio C HamanoApr 14, 2026
  108. Harald NordgrenApr 14, 2026
  109. Phillip WoodApr 15, 2026
  110. Harald NordgrenApr 14, 2026
  111. Harald NordgrenApr 15, 2026
  112. Phillip WoodApr 15, 2026
  113. Harald NordgrenApr 15, 2026
  114. Phillip WoodApr 15, 2026
  115. Junio C HamanoApr 14, 2026
  116. Harald NordgrenApr 14, 2026
  117. Junio C HamanoApr 14, 2026
  118. Harald NordgrenApr 16, 2026
  119. Junio C HamanoApr 16, 2026
  120. Harald NordgrenApr 16, 2026
  121. 0/5 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 15, 2026
  122. 1/5 stash: add --label-ours, --label-theirs, --label-base for applyHarald Nordgren via GitGitGadget, Apr 15, 2026
  123. 2/5 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 15, 2026
  124. 3/5 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 15, 2026
  125. 4/5 checkout: rollback lock on early returns in merge_working_treeHarald Nordgren via GitGitGadget, Apr 15, 2026
  126. 5/5 checkout -m: autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 15, 2026
  127. 0/5 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 15, 2026
  128. 1/5 stash: add --label-ours, --label-theirs, --label-base for applyHarald Nordgren via GitGitGadget, Apr 15, 2026
  129. 2/5 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 15, 2026
  130. 3/5 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 15, 2026
  131. 4/5 checkout: rollback lock on early returns in merge_working_treeHarald Nordgren via GitGitGadget, Apr 15, 2026
  132. 5/5 checkout -m: autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 15, 2026
  133. Phillip WoodApr 24, 2026
  134. Comments on Phillip's reviewHarald Nordgren, Apr 24, 2026
  135. Harald NordgrenApr 21, 2026
  136. Phillip WoodApr 21, 2026
  137. Harald NordgrenApr 22, 2026
  138. Phillip WoodApr 24, 2026
  139. 0/5 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 24, 2026
  140. 1/5 stash: add --label-ours, --label-theirs, --label-base for applyHarald Nordgren via GitGitGadget, Apr 24, 2026
  141. Phillip WoodApr 28, 2026
  142. checkout: add --autostash option for branch switchingHarald Nordgren, Apr 28, 2026
  143. 2/5 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 24, 2026
  144. Phillip WoodApr 28, 2026
  145. 3/5 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 24, 2026
  146. Phillip WoodApr 28, 2026
  147. checkout: add --autostash option for branch switchingHarald Nordgren, Apr 28, 2026
  148. 4/5 checkout: rollback lock on early returns in merge_working_treeHarald Nordgren via GitGitGadget, Apr 24, 2026
  149. Phillip WoodApr 28, 2026
  150. 5/5 checkout -m: autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 24, 2026
  151. Phillip WoodApr 28, 2026
  152. checkout: add --autostash option for branch switchingHarald Nordgren, Apr 28, 2026
  153. Phillip WoodApr 28, 2026
  154. 0/5 checkout: 'autostash' for branch switchingHarald Nordgren via GitGitGadget, Apr 28, 2026
  155. 1/5 stash: add --label-ours, --label-theirs, --label-base for applyHarald Nordgren via GitGitGadget, Apr 28, 2026
  156. 2/5 sequencer: allow create_autostash to run silentlyHarald Nordgren via GitGitGadget, Apr 28, 2026
  157. 3/5 sequencer: teach autostash apply to take optional conflict marker labelsHarald Nordgren via GitGitGadget, Apr 28, 2026
  158. 4/5 checkout: rollback lock on early returns in merge_working_treeHarald Nordgren via GitGitGadget, Apr 28, 2026
  159. 5/5 checkout -m: autostash when switching branchesHarald Nordgren via GitGitGadget, Apr 28, 2026
  160. Phillip WoodApr 29, 2026
  161. Phillip WoodApr 29, 2026
  162. checkout: add --autostash option for branch switchingHarald Nordgren, Apr 29, 2026
  163. 0/5 checkout: 'autostash' for branch switchingHarald Nordgren, May 7, 2026
  164. Phillip WoodMay 8, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.