Re: [PATCH v8 1/4] stash: add --ours-label, --theirs-label, --base-label for apply
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 10, 2026, 16:15 UTC
- Message-ID
- <xmqqik9ypzax.fsf@gitster.g>
- In-Reply-To
- <0d1c7bf2-6404-4779-a0d6-6db592510a04@gmail.com>
Phillip Wood <phillip.wood123@gmail.com> writes:
>> +test_expect_success 'apply with empty conflict labels' ' > > Why do we want to support empty labels rather than making them an error?
Why not?
There are applications that do not require, and prefer to have more stable output that will not be affected by UI updates to improve human-user experience. Even though rerere database is not populated with the facility this patch implements, we can see in
$ grep -C2 -e '^\([<=>]\)\1\{6,\}$' .git/rr-cache/*/preimage*how having labels make the output more noisy, and more importantly, will make it misleading given how rerere is designed to work, treating the same merge conflicts in both directions equivalents. It is not a huge stretch of imagination that our users will find similar needs, I would imagine.