git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 22, 2016, 20:51 UTC
Message-ID
<xmqqinx1kkus.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160622204836.GA4628@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 9 quoted lines
>> I can see how this works for "git -C ... rev-parse ..." or any other
>> built-in commands, but I am not sure if this is sufficient when any
>> non-built-in command is used in the perf framework.  How does it
>> interact with GIT_EXEC_PATH we set in ../test-lib.sh that is
>> dot-sourced by ./perf-lib.sh that everybody dot-sources?
>
> I didn't test it but it should work because we are pointing to
> bin-wrappers/git, which will override GIT_EXEC_PATH, and stick itself at
> the front of the PATH.

Ah, yes, bin-wrappers/git is not the real binary we just have built but overrides GIT_EXEC_PATH to point at the matching version. I forgot about that.

Thanks.
Previous: Jeff KingNext: Jeff King
Message 7 of 8 in “t/perf tests against older versions”
  1. 0/2 t/perf tests against older versionsJeff King, Jun 22, 2016
  2. 1/2 t/perf: fix regression in testing older versions of gitJeff King, Jun 22, 2016
  3. Johannes SchindelinJun 22, 2016
  4. Johannes SchindelinJun 22, 2016
  5. Junio C HamanoJun 22, 2016
  6. Jeff KingJun 22, 2016
  7. Junio C HamanoJun 22, 2016
  8. 2/2 p4211: explicitly disable renames in no-rename testJeff King, Jun 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.