From: Junio C Hamano <gitster@pobox.com>
Date: Wed, 22 Jun 2016 20:51:55 GMT
Subject: Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git
Message-ID: <xmqqinx1kkus.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160622204836.GA4628@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

>> I can see how this works for "git -C ... rev-parse ..." or any other
>> built-in commands, but I am not sure if this is sufficient when any
>> non-built-in command is used in the perf framework.  How does it
>> interact with GIT_EXEC_PATH we set in ../test-lib.sh that is
>> dot-sourced by ./perf-lib.sh that everybody dot-sources?
>
> I didn't test it but it should work because we are pointing to
> bin-wrappers/git, which will override GIT_EXEC_PATH, and stick itself at
> the front of the PATH.

Ah, yes, bin-wrappers/git is not the real binary we just have built
but overrides GIT_EXEC_PATH to point at the matching version.  I
forgot about that.

Thanks.