Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git

From: Jeff King <peff@peff.net>
Date: Jun 22, 2016, 20:48 UTC
Message-ID: <20160622204836.GA4628@sigill.intra.peff.net>
In-Reply-To: <xmqqmvmdkl3y.fsf@gitster.mtv.corp.google.com>

On Wed, Jun 22, 2016 at 01:46:25PM -0700, Junio C Hamano wrote:

Show 14 quoted lines

> Jeff King <peff@peff.net> writes:
> 
> > So let's introduce a new variable, $MODERN_GIT, that we can
> > use both in perf-lib and in the test setup to get a reliable
> > set of git features (we might change git and break some
> > tests, of course, but $MODERN_GIT is tied to the same
> > version of git as the t/perf scripts, so they can be fixed
> > or adjusted together).
> 
> I can see how this works for "git -C ... rev-parse ..." or any other
> built-in commands, but I am not sure if this is sufficient when any
> non-built-in command is used in the perf framework.  How does it
> interact with GIT_EXEC_PATH we set in ../test-lib.sh that is
> dot-sourced by ./perf-lib.sh that everybody dot-sources?

I didn't test it but it should work because we are pointing to bin-wrappers/git, which will override GIT_EXEC_PATH, and stick itself at the front of the PATH.

-Peff