Re: [PATCH 1/2] t/perf: fix regression in testing older versions of git
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 22, 2016, 20:46 UTC
- Message-ID
- <xmqqmvmdkl3y.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20160622194013.GA1697@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 6 quoted lines
> So let's introduce a new variable, $MODERN_GIT, that we can > use both in perf-lib and in the test setup to get a reliable > set of git features (we might change git and break some > tests, of course, but $MODERN_GIT is tied to the same > version of git as the t/perf scripts, so they can be fixed > or adjusted together).
I can see how this works for "git -C ... rev-parse ..." or any other built-in commands, but I am not sure if this is sufficient when any non-built-in command is used in the perf framework. How does it interact with GIT_EXEC_PATH we set in ../test-lib.sh that is dot-sourced by ./perf-lib.sh that everybody dot-sources?