git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/2] p4211: explicitly disable renames in no-rename test

From
Jeff King <peff@peff.net>
Date
Jun 22, 2016, 19:40 UTC
Message-ID
<20160622194051.GB1697@sigill.intra.peff.net>
In-Reply-To
<20160622193904.GA1509@sigill.intra.peff.net>

p4211 tests line-log performance both with and without "-M". In v2.9.0, the case without "-M" appears to have regressed badly, but that is only because we flipped on renames by default.

Let's have the test explicitly disable renames to get consistent timings (and to match the presumed intent of the test, which is to see the effects with and without renames).

Signed-off-by: Jeff King <peff@peff.net>
---
 t/perf/p4211-line-log.sh | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/perf/p4211-line-log.sh b/t/perf/p4211-line-log.sh
index 3d074b0..b7ff68d 100755
--- a/t/perf/p4211-line-log.sh
+++ b/t/perf/p4211-line-log.sh
@@ -23,11 +23,11 @@ test_perf 'git log --follow (baseline for -M)' '
 	git log --oneline --follow -- "$file" >/dev/null
 '
 
-test_perf 'git log -L' '
-	git log -L 1:"$file" >/dev/null
+test_perf 'git log -L (renames off)' '
+	git log --no-renames -L 1:"$file" >/dev/null
 '
 
-test_perf 'git log -M -L' '
+test_perf 'git log -L (renames on)' '
 	git log -M -L 1:"$file" >/dev/null
 '
 
-- 
2.9.0.204.g1499a7b
Previous: Junio C Hamano
Message 8 of 8 in “t/perf tests against older versions”
  1. 0/2 t/perf tests against older versionsJeff King, Jun 22, 2016
  2. 1/2 t/perf: fix regression in testing older versions of gitJeff King, Jun 22, 2016
  3. Johannes SchindelinJun 22, 2016
  4. Johannes SchindelinJun 22, 2016
  5. Junio C HamanoJun 22, 2016
  6. Jeff KingJun 22, 2016
  7. Junio C HamanoJun 22, 2016
  8. 2/2 p4211: explicitly disable renames in no-rename testJeff King, Jun 22, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.