Re: Question about get_cached_commit_buffer()

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 21, 2018, 23:03 UTC
Message-ID: <xmqqinaqx7wp.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180221225002.GB7944@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Out of curiosity, do you actually use --show-all for anything?

Absolutely not. I'd actually love it if I could say "not anymore" instead, but I haven't had an opportunity to debug the revision traversal code for quite some time so I do not even remember when was the last time I used it, which disqualifies me from saying even that.

> So what I'm wondering is whether we should consider just ripping it out
> (but I'm OK with keeping it, as once the commit-buffer stuff is fixed,
> it's probably not hurting anybody).

I see no problem in removing it. With more "interesting" features relying on post-processing (like 'simplify-merges'), show_all whose primary focus was how limit_list() behaves soft of outlived its usefulness, I would think.