git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

From
Jeff King <peff@peff.net>
Date
Feb 21, 2018, 23:34 UTC
Message-ID
<20180221233433.GA29992@sigill.intra.peff.net>
In-Reply-To
<07690508-e6c6-5b3b-6c03-5ad83c9c3501@gmail.com>
On Wed, Feb 21, 2018 at 02:19:17PM -0500, Derrick Stolee wrote:
Show 10 quoted lines
> > These behaviors are undocumented, untested, and unlikely to be
> > expected by users or other software attempting to parse this output.
> > 
> > Helped-by: Jeff King <peff@peff.net>
> > Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
> 
> This would be a good time to allow multiple authors, or to just change the
> author, since this is exactly the diff you (Peff) provided in an earlier
> email. The commit message hopefully summarizes our discussion, but I welcome
> edits.

The point is moot if we take the revision I just sent (though in retrospect I really ought to have put in a Reported-by: for you there).

But some communities are settling on Co-authored-by as a trailer for this case. And GitHub has started parsing and showing that along with author information:

  https://github.com/blog/2496-commit-together-with-co-authors
-Peff
Previous: Derrick StoleeNext: Jeff King
Message 8 of 17 in “Question about get_cached_commit_buffer()”
  1. Derrick StoleeFeb 20, 2018
  2. Jeff KingFeb 20, 2018
  3. Derrick StoleeFeb 21, 2018
  4. Jeff KingFeb 21, 2018
  5. Jeff KingFeb 21, 2018
  6. commit: drop uses of get_cached_commit_buffer()Derrick Stolee, Feb 21, 2018
  7. Derrick StoleeFeb 21, 2018
  8. Jeff KingFeb 21, 2018
  9. Jeff KingFeb 21, 2018
  10. Stefan BellerFeb 21, 2018
  11. Jeff KingFeb 21, 2018
  12. Derrick StoleeFeb 22, 2018
  13. Junio C HamanoFeb 21, 2018
  14. Jeff KingFeb 21, 2018
  15. Junio C HamanoFeb 21, 2018
  16. revision: drop --show-all optionJeff King, Feb 21, 2018
  17. Linus TorvaldsFeb 21, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.