Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

From: Stefan Beller <sbeller@google.com>
Date: Feb 21, 2018, 23:22 UTC
Message-ID: <CAGZ79kZz+hC+eXxa2A-NpnCZa-LikWDaegfijUjHp5CCenwQvA@mail.gmail.com>
In-Reply-To: <20180221231338.GC7944@sigill.intra.peff.net>

Show 5 quoted lines

> Subject: [PATCH] commit: drop uses of get_cached_commit_buffer()
> ---
>  builtin/rev-list.c | 2 +-
>  log-tree.c         | 3 ---
>  2 files changed, 1 insertion(+), 4 deletions(-)

Now if we'd get around to rewrite pretty.c as well, we could make it static, giving a stronger reason of not using that function. But it looks a bit complicated to me, who is not familiar in that area of the code.

Thanks for making less use of this suboptimal API, Stefan