Re: Question about get_cached_commit_buffer()

From: Jeff King <peff@peff.net>
Date: Feb 21, 2018, 22:50 UTC
Message-ID: <20180221225002.GB7944@sigill.intra.peff.net>
In-Reply-To: <xmqqtvuax9te.fsf@gitster-ct.c.googlers.com>

On Wed, Feb 21, 2018 at 02:22:05PM -0800, Junio C Hamano wrote:

Show 8 quoted lines

> > I think that repeating the oid is intentional; the point is to dump how
> > the traversal code is hitting the endpoints, even if we do so multiple
> > times.
> >
> > The --oneline behavior just looks like a bug. I think --format is broken
> > with --show-all, too (it does not show anything!).
> 
> I do not know about the --format thing,[...]

Hmm, maybe it is fine. I thought before that I got funny output out of "git log --show-all --format", but I can't seem to reproduce it now.

> being a bug is correct.  I've known about the oneline that does not
> show anything other than the oid (not even end-of-line) for unparsed
> commits for a long time---I just didn't bother looking into fixing
> it exactly because this is only a debugging aid ;-)

Out of curiosity, do you actually use --show-all for anything? I didn't even know it existed until this thread, and AFAICT nobody but Linus has ever recommended its use. And it does not even seem that useful as a general debugging aid.

So what I'm wondering is whether we should consider just ripping it out (but I'm OK with keeping it, as once the commit-buffer stuff is fixed, it's probably not hurting anybody).

-Peff