Re: [PATCH] commit: drop uses of get_cached_commit_buffer()

From: Jeff King <peff@peff.net>
Date: Feb 21, 2018, 23:29 UTC
Message-ID: <20180221232939.GE7944@sigill.intra.peff.net>
In-Reply-To: <CAGZ79kZz+hC+eXxa2A-NpnCZa-LikWDaegfijUjHp5CCenwQvA@mail.gmail.com>

On Wed, Feb 21, 2018 at 03:22:02PM -0800, Stefan Beller wrote:

Show 11 quoted lines

> > Subject: [PATCH] commit: drop uses of get_cached_commit_buffer()
> > ---
> >  builtin/rev-list.c | 2 +-
> >  log-tree.c         | 3 ---
> >  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> Now if we'd get around to rewrite pretty.c as well, we could make it static,
> giving a stronger reason of not using that function. But it looks a bit
> complicated to me, who is not familiar in that area of the code.
> 
> Thanks for making less use of this suboptimal API,

I'm not sure the API is suboptimal. It's not wrong to ask "do you have a cached copy of this?". It was just being used poorly here. :)

See the discussion in

  https://public-inbox.org/git/20180221184811.GD4333@sigill.intra.peff.net/

-Peff