Re: [PATCH 2/2] Makefile: quote $INSTLIBDIR when passing it to sed
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 24, 2018, 00:53 UTC
- Message-ID
- <xmqqin8h8lx7.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20180423232535.GD25128@aiede.svl.corp.google.com>
Jonathan Nieder <jrnieder@gmail.com> writes:
Show 10 quoted lines
> diff --git a/Makefile b/Makefile
> index 8f4cb506ff..727eca5d0a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2108,7 +2108,7 @@ GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES Makefile
> INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
> INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
> sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
> - -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
> + -e 's=@@INSTLIBDIR@@='"$$INSTLIBDIR"'=g' \Good find. FWIW, I'd find it a lot easier to read if the whole thing were enclosed inside a single pair of dq.