Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

From: Johannes Sixt <j6t@kdbg.org>
Date: Dec 1, 2017, 17:25 UTC
Message-ID: <97acc3d3-5c6a-2e65-a372-24def5b21d54@kdbg.org>
In-Reply-To: <alpine.DEB.2.21.1.1712011812250.98586@virtualbox>

Am 01.12.2017 um 18:13 schrieb Johannes Schindelin:

Show 23 quoted lines

> Hi Hannes,
> 
> On Fri, 1 Dec 2017, Johannes Sixt wrote:
> 
>> Am 29.11.2017 um 16:56 schrieb Dan Jacques:
>>> @@ -1989,6 +1986,15 @@ GIT-PERL-DEFINES: FORCE
>>>         	echo "$$FLAGS" >$@; \
>>>         fi
>>>    +GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak
>>> Makefile
>>> +	$(QUIET_GEN)$(RM) $@ && \
>>> +	INSTLIBDIR=`MAKEFLAGS= $(MAKE) -C perl -s --no-print-directory
>>> instlibdir` && \
>>> +	INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
>>> +	INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" &&
>>> \
>>> +	sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
>>
>> This doesn't work, unfortunately. When $(pathsep) is ';', we get an incomplete
>> sed expression because ';' is also a command separator in the sed language.
> 
> Funny, I tried this also with ';' as pathsep, and it worked in the Git for
> Windows SDK...

My ancient sed vs. your modern sed, perhaps? I can check this on Monday.

-- Hannes