Re: [PATCH 1/2] Makefile: remove unused @@PERLLIBDIR@@ substitution variable

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 24, 2018, 02:11 UTC
Message-ID: <xmqqin8h73qb.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180423232422.GC25128@aiede.svl.corp.google.com>

Jonathan Nieder <jrnieder@gmail.com> writes:

> Junio noticed that this variable is not quoted correctly when it is
> passed to sed.  As a shell-quoted string, it should be inside
> single-quotes like $(perllibdir_relative_SQ), not outside them like
> $INSTLIBDIR.

Spreading credit is very much appreciated, but in this case the above belongs below the three-dash fold, I would think, as the incorrect quoting become irrelevant.

Will queue.  Thanks.

Show 23 quoted lines

> In fact, this substitution variable is not used.  Simplify by removing
> it.
>
> Reported-by: Junio C Hamano <gitster@pobox.com>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> ---
> An unrelated cleanup noticed while looking over this code.
>
>  Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 154929f1c8..8f4cb506ff 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -2109,7 +2109,6 @@ GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES Makefile
>  	INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
>  	sed -e 's=@@PATHSEP@@=$(pathsep)=g' \
>  	    -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \
> -	    -e 's=@@PERLLIBDIR@@='$(perllibdir_SQ)'=g' \
>  	    -e 's=@@PERLLIBDIR_REL@@=$(perllibdir_relative_SQ)=g' \
>  	    -e 's=@@GITEXECDIR_REL@@=$(gitexecdir_relative_SQ)=g' \
>  	    -e 's=@@LOCALEDIR_REL@@=$(localedir_relative_SQ)=g' \