Re: [PATCH v4 1/4] Makefile: generate Perl header from template file

From: Dan Jacques <dnj@google.com>
Date: Dec 1, 2017, 18:18 UTC
Message-ID: <20171201181845.8454-1-dnj@google.com>
In-Reply-To: <97acc3d3-5c6a-2e65-a372-24def5b21d54@kdbg.org>

On Fri, 1 Dec 2017, Johannes Sixt wrote:

Show 7 quoted lines

>>> This doesn't work, unfortunately. When $(pathsep) is ';', we get an
>>> incomplete sed expression because ';' is also a command separator in the sed language.
>>
>> Funny, I tried this also with ';' as pathsep, and it worked in the Git for
>> Windows SDK...
>
> My ancient sed vs. your modern sed, perhaps? I can check this on Monday.

If you wouldn't mind, that would be much appreciated. Did you actually observe this issue, or is it just coming up in review?

I am not a `sed` wizard, but perhaps the tool is ignoring the semicolon because it's in the middle of the "s" expression? The shell may similarly be ignoring it because it's nested in between single-quotes?

-Dan