Re: [PATCH v4 1/4] Makefile: generate Perl header from template file
- From
Johannes Sixt <j6t@kdbg.org>
- Date
- Dec 1, 2017, 16:59 UTC
- Message-ID
- <3c897f4c-0cb5-ca44-f144-598a623c1dc3@kdbg.org>
- In-Reply-To
- <20171129155637.89075-2-dnj@google.com>
Am 29.11.2017 um 16:56 schrieb Dan Jacques:
Show 10 quoted lines
> @@ -1989,6 +1986,15 @@ GIT-PERL-DEFINES: FORCE
> echo "$$FLAGS" >$@; \
> fi
>
> +GIT-PERL-HEADER: $(PERL_HEADER_TEMPLATE) GIT-PERL-DEFINES perl/perl.mak Makefile
> + $(QUIET_GEN)$(RM) $@ && \
> + INSTLIBDIR=`MAKEFLAGS= $(MAKE) -C perl -s --no-print-directory instlibdir` && \
> + INSTLIBDIR_EXTRA='$(PERLLIB_EXTRA_SQ)' && \
> + INSTLIBDIR="$$INSTLIBDIR$${INSTLIBDIR_EXTRA:+:$$INSTLIBDIR_EXTRA}" && \
> + sed -e 's=@@PATHSEP@@=$(pathsep)=g' \This doesn't work, unfortunately. When $(pathsep) is ';', we get an incomplete sed expression because ';' is also a command separator in the sed language.
Show 6 quoted lines
> + -e 's=@@INSTLIBDIR@@='$$INSTLIBDIR'=g' \ > + $< >$@+ && \ > + mv $@+ $@ > > .PHONY: gitweb > gitweb:
-- Hannes