Re: [PATCH 04/11] sha1dc: mark forgotten message for translation
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jan 12, 2021, 19:40 UTC
- Message-ID
- <xmqqim823pwa.fsf@gitster.c.googlers.com>
- In-Reply-To
- <X/2J8KL/Jig/xttF@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 21 quoted lines
> On Tue, Jan 12, 2021 at 08:47:35AM +0000, Johannes Schindelin via GitGitGadget wrote:
>
>> diff --git a/sha1dc_git.c b/sha1dc_git.c
>> index 5c300e812e0..fecf5da1483 100644
>> --- a/sha1dc_git.c
>> +++ b/sha1dc_git.c
>> @@ -18,7 +18,7 @@ void git_SHA1DCFinal(unsigned char hash[20], SHA1_CTX *ctx)
>> {
>> if (!SHA1DCFinal(hash, ctx))
>> return;
>> - die("SHA-1 appears to be part of a collision attack: %s",
>> + die(_("SHA-1 appears to be part of a collision attack: %s"),
>> hash_to_hex_algop(hash, &hash_algos[GIT_HASH_SHA1]));
>
> I didn't find any list discussion, but I think I may have actually left
> this untranslated intentionally. Like a BUG(), we'd expect it to come up
> basically never. And when it does, being able to search for the exact
> wording online may be more important than providing a translated
> version.
>
> It probably doesn't matter that much either way, though.I can believe if this was intentionally left untranslated for the reasons you stated. Without introducing "message ID" that can be universally readable, so that customers can report "We got E42234 when running Git version 1.2.3.4", that is the best we could do.
But I am OK to see this translated, too.
Thanks.