Re: [PATCH 00/11] [RFH] Introduce support for GETTEXT_POISON=rot13
- From
Jeff King <peff@peff.net>
- Date
- Jan 13, 2021, 07:32 UTC
- Message-ID
- <X/6h+8UC6N1MfZ0Q@coredump.intra.peff.net>
- In-Reply-To
- <xmqqa6te3per.fsf@gitster.c.googlers.com>
On Tue, Jan 12, 2021 at 11:50:52AM -0800, Junio C Hamano wrote:
Show 9 quoted lines
> Jeff King <peff@peff.net> writes: > > > Likewise, I'm not sure that one can reliably rot13 an output for > > test_i18ncmp. It could contain mixed translated and untranslated bits > > from different messages. > > As long as <rot13>...</rot13> marking can be trusted (and it cannot > be, but if we declare it is OK to punt, then by definition we can), > I think the messages can be compared.
Good point. I should have looked at the implementation more carefully before responding (and I agree that while not foolproof, tagging like that would work OK in practice).
-Peff