Re: [PATCH 04/11] sha1dc: mark forgotten message for translation

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 15, 2021, 15:43 UTC
Message-ID: <nycvar.QRO.7.76.6.2101151639030.52@tvgsbejvaqbjf.bet>
In-Reply-To: <X/2J8KL/Jig/xttF@coredump.intra.peff.net>

Hi Peff,

On Tue, 12 Jan 2021, Jeff King wrote:

Show 19 quoted lines

> On Tue, Jan 12, 2021 at 08:47:35AM +0000, Johannes Schindelin via GitGitGadget wrote:
>
> > diff --git a/sha1dc_git.c b/sha1dc_git.c
> > index 5c300e812e0..fecf5da1483 100644
> > --- a/sha1dc_git.c
> > +++ b/sha1dc_git.c
> > @@ -18,7 +18,7 @@ void git_SHA1DCFinal(unsigned char hash[20], SHA1_CTX *ctx)
> >  {
> >  	if (!SHA1DCFinal(hash, ctx))
> >  		return;
> > -	die("SHA-1 appears to be part of a collision attack: %s",
> > +	die(_("SHA-1 appears to be part of a collision attack: %s"),
> >  	    hash_to_hex_algop(hash, &hash_algos[GIT_HASH_SHA1]));
>
> I didn't find any list discussion, but I think I may have actually left
> this untranslated intentionally. Like a BUG(), we'd expect it to come up
> basically never. And when it does, being able to search for the exact
> wording online may be more important than providing a translated
> version.

I disagree with that reasoning. By that rationale, any message we deem to be somewhat rare should be _untranslated_.

A much better rule, at least from my perspective is: is the target audience the Git users? If so, the message is to be translated. If not, then not.

In this instance, it is quite obviously targeting the Git users who need to understand why the command they tried to run was failing. The test in t0013 is totally agreeing with this:

	test_expect_success 'test-sha1 detects shattered pdf' '
		test_must_fail test-tool sha1 <"$TEST_DATA/shattered-1.pdf" 2>err &&
		test_i18ngrep collision err &&
		grep 38762cf7f55934b34d179ae6a4c80cadccbb7f0a err
	'

Notice that `test_i18ngrep`? It tells me that we expect this message to be translated.

Ciao, Dscho