Re: [PATCH 04/11] sha1dc: mark forgotten message for translation

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 19, 2021, 15:52 UTC
Message-ID: <nycvar.QRO.7.76.6.2101191648400.52@tvgsbejvaqbjf.bet>
In-Reply-To: <xmqqim7uj6p5.fsf@gitster.c.googlers.com>

Hi Junio,

On Mon, 18 Jan 2021, Junio C Hamano wrote:

Show 16 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
>
> >> That's what I was getting at. The audience is really Git developers,
> >> just like it would be for a BUG(). We don't expect either of those
> >> things to happen.
> >
> > While a SHA-1 collision might not be anything we expect to happen, I am
> > fairly certain it won't be a bug in Git causing it. Nor will it be
> > anything that core Git developers have to react on. For those reasons, I
> > disagree that core Git developers are the target audience of this message.
>
> I do not know if this is what Peff meant by "the audience is really
> Git developers", but when any end-user encounters this message, we
> want to learn about it a lot more urgently than all the ordinary
> "there is no such command line option", so in that sense, even it
> is not "a bug in git", it is more special than ordinary errors.

I suggest that we modify the message to state exactly that: "Please contact the Git mailing list at git@vger.kernel.org about this". And then mark the message for translation, so that even Git users with low/no knowledge of the English language are in a position to help us.

Ciao, Dscho

P.S.: Yes, I realize that this means we could receive a message reporting a SHA-1 collision written in, say, Chinese. Is this a problem? I don't think so. In any case, this would still be much better than keeping the message untranslated and _not_ receiving a mail about it.