Re: t6044 broken on pu
- From
Junio C Hamano <gitster@pobox.com>
- Date
- May 9, 2016, 18:36 UTC
- Message-ID
- <xmqqh9e7ulie.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <xmqqr3dbulyp.fsf@gitster.mtv.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 11 quoted lines
> Yes, I think the comment should just go. Nobody used that alphabet > form since it was written in d17cf5f3 (tests: Introduce test_seq, > 2012-08-04). > >> I don't really care either way whether it is replaced or not (at one >> point there were some people really interested in NO_PERL not even using >> one-liners in the test suite, but I am not one of them). > > Neither am I, but I think it is prudent to drop that "letters". The > comment even says the letter form is not portable already, so the > mention of GNU seq(1) is not helping at all.
-- >8 -- Subject: test-lib-functions.sh: remove misleading comment on test_seq
We never used the "letters" form since we came up with "test_seq" to replace use of non-portable "seq" in our test script, which we introduced it at d17cf5f3 (tests: Introduce test_seq, 2012-08-04).
We use this helper to either iterate for N times (i.e. the values on the lines do not even matter), or just to get N distinct strings (i.e. the values on the lines themselves do not really matter, but we care that they are different from each other and reproducible).
Stop promising that we may allow using "letters"; this would open an easier reimplementation that does not rely on $PERL, if somebody later wants to.
Signed-off-by: Junio C Hamano <gitster@pobox.com> --- t/test-lib-functions.sh | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh index 8d99eb3..cc9f61d 100644 --- a/t/test-lib-functions.sh +++ b/t/test-lib-functions.sh @@ -718,20 +718,13 @@ test_cmp_rev () { test_cmp expect.rev actual.rev } -# Print a sequence of numbers or letters in increasing order. This is -# similar to GNU seq(1), but the latter might not be available -# everywhere (and does not do letters). It may be used like: -# -# for i in $(test_seq 100) -# do -# for j in $(test_seq 10 20) -# do -# for k in $(test_seq a z) -# do -# echo $i-$j-$k -# done -# done -# done +# Print a sequence of integers in increasing order, either with +# two arguments (start and end): +# +# test_seq 1 5 -- outputs 1 2 3 4 5 one line at a time +# +# or with one argument (end), in which case it starts counting +# from 1. test_seq () { case $# in