git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t6044 broken on pu

From
Jeff King <peff@peff.net>
Date
May 10, 2016, 02:41 UTC
Message-ID
<20160510024151.GB16965@sigill.intra.peff.net>
In-Reply-To
<xmqqh9e7ulie.fsf@gitster.mtv.corp.google.com>
On Mon, May 09, 2016 at 11:36:09AM -0700, Junio C Hamano wrote:
Show 16 quoted lines
> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Yes, I think the comment should just go.  Nobody used that alphabet
> > form since it was written in d17cf5f3 (tests: Introduce test_seq,
> > 2012-08-04).
> >
> >> I don't really care either way whether it is replaced or not (at one
> >> point there were some people really interested in NO_PERL not even using
> >> one-liners in the test suite, but I am not one of them).
> >
> > Neither am I, but I think it is prudent to drop that "letters".  The
> > comment even says the letter form is not portable already, so the
> > mention of GNU seq(1) is not helping at all.
> 
> -- >8 --
> Subject: test-lib-functions.sh: remove misleading comment on test_seq

Thanks, this (and the actual implementation change) both look good to me, and I'm happy with either or both being applied.

-Peff
Previous: Eric Sunshine
Message 20 of 20 in “t6044 broken on pu”
  1. Torsten BögershausenMay 7, 2016
  2. Andreas SchwabMay 7, 2016
  3. Ramsay JonesMay 7, 2016
  4. Ramsay JonesMay 7, 2016
  5. Torsten BögershausenMay 7, 2016
  6. Junio C HamanoMay 8, 2016
  7. Torsten BögershausenMay 8, 2016
  8. Junio C HamanoMay 8, 2016
  9. Torsten BögershausenMay 9, 2016
  10. Junio C HamanoMay 9, 2016
  11. demerphqMay 9, 2016
  12. Jeff KingMay 9, 2016
  13. Eric SunshineMay 9, 2016
  14. Jeff KingMay 9, 2016
  15. Junio C HamanoMay 9, 2016
  16. Junio C HamanoMay 9, 2016
  17. Eric SunshineMay 9, 2016
  18. Junio C HamanoMay 9, 2016
  19. Eric SunshineMay 9, 2016
  20. Jeff KingMay 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.