git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t6044 broken on pu

From
Eric Sunshine <sunshine@sunshineco.com>
Date
May 9, 2016, 21:27 UTC
Message-ID
<CAPig+cQopZta6bs8JBV23iP4xpaPk2Y4UZ5E6rWeTEtYxW=uJA@mail.gmail.com>
In-Reply-To
<xmqqeg9bszw0.fsf@gitster.mtv.corp.google.com>
On Mon, May 9, 2016 at 5:08 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 21 quoted lines
> Subject: [PATCH] test-lib-functions.sh: rewrite test_seq without Perl
>
> Rewrite the 'seq' imitation only with commands and features
> that are typically found as built-in in modern POSIX shells,
> instead of relying on Perl to run a single-liner.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> @@ -679,7 +679,12 @@ test_seq () {
>         2)      ;;
>         *)      error "bug in the test script: not 1 or 2 parameters to test_seq" ;;
>         esac
> -       perl -le 'print for $ARGV[0]..$ARGV[1]' -- "$@"
> +       test_seq_counter__=$1
> +       while test "$test_seq_counter__" -le "$2"
> +       do
> +               echo "$test_seq_counter__"
> +               test_seq_counter__=$(( $test_seq_counter__ + 1 ))
> +       done
>  }
Looks (obviously) correct and works as expected on Mac and BSD.
Previous: Junio C HamanoNext: Jeff King
Message 19 of 20 in “t6044 broken on pu”
  1. Torsten BögershausenMay 7, 2016
  2. Andreas SchwabMay 7, 2016
  3. Ramsay JonesMay 7, 2016
  4. Ramsay JonesMay 7, 2016
  5. Torsten BögershausenMay 7, 2016
  6. Junio C HamanoMay 8, 2016
  7. Torsten BögershausenMay 8, 2016
  8. Junio C HamanoMay 8, 2016
  9. Torsten BögershausenMay 9, 2016
  10. Junio C HamanoMay 9, 2016
  11. demerphqMay 9, 2016
  12. Jeff KingMay 9, 2016
  13. Eric SunshineMay 9, 2016
  14. Jeff KingMay 9, 2016
  15. Junio C HamanoMay 9, 2016
  16. Junio C HamanoMay 9, 2016
  17. Eric SunshineMay 9, 2016
  18. Junio C HamanoMay 9, 2016
  19. Eric SunshineMay 9, 2016
  20. Jeff KingMay 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.