git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: t6044 broken on pu

From
Eric Sunshine <sunshine@sunshineco.com>
Date
May 9, 2016, 20:10 UTC
Message-ID
<CAPig+cSg7e=aV4YmJ2iioo6GHB7ZeNREKC-20X47F=5MbzDQLA@mail.gmail.com>
In-Reply-To
<xmqqh9e7ulie.fsf@gitster.mtv.corp.google.com>
On Mon, May 9, 2016 at 2:36 PM, Junio C Hamano <gitster@pobox.com> wrote:
Show 40 quoted lines
> Subject: test-lib-functions.sh: remove misleading comment on test_seq
>
> We never used the "letters" form since we came up with "test_seq" to
> replace use of non-portable "seq" in our test script, which we
> introduced it at d17cf5f3 (tests: Introduce test_seq, 2012-08-04).
>
> We use this helper to either iterate for N times (i.e. the values on
> the lines do not even matter), or just to get N distinct strings
> (i.e. the values on the lines themselves do not really matter, but
> we care that they are different from each other and reproducible).
>
> Stop promising that we may allow using "letters"; this would open an
> easier reimplementation that does not rely on $PERL, if somebody
> later wants to.
>
> Signed-off-by: Junio C Hamano <gitster@pobox.com>
> ---
> diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
> @@ -718,20 +718,13 @@ test_cmp_rev () {
> -# Print a sequence of numbers or letters in increasing order.  This is
> -# similar to GNU seq(1), but the latter might not be available
> -# everywhere (and does not do letters).  It may be used like:
> -#
> -#      for i in $(test_seq 100)
> -#      do
> -#              for j in $(test_seq 10 20)
> -#              do
> -#                      for k in $(test_seq a z)
> -#                      do
> -#                              echo $i-$j-$k
> -#                      done
> -#              done
> -#      done
> +# Print a sequence of integers in increasing order, either with
> +# two arguments (start and end):
> +#
> +#     test_seq 1 5 -- outputs 1 2 3 4 5 one line at a time
> +#
> +# or with one argument (end), in which case it starts counting
> +# from 1.
This new documentation is quite readable. Thanks.
>  test_seq () {
>         case $# in
Previous: Junio C HamanoNext: Junio C Hamano
Message 17 of 20 in “t6044 broken on pu”
  1. Torsten BögershausenMay 7, 2016
  2. Andreas SchwabMay 7, 2016
  3. Ramsay JonesMay 7, 2016
  4. Ramsay JonesMay 7, 2016
  5. Torsten BögershausenMay 7, 2016
  6. Junio C HamanoMay 8, 2016
  7. Torsten BögershausenMay 8, 2016
  8. Junio C HamanoMay 8, 2016
  9. Torsten BögershausenMay 9, 2016
  10. Junio C HamanoMay 9, 2016
  11. demerphqMay 9, 2016
  12. Jeff KingMay 9, 2016
  13. Eric SunshineMay 9, 2016
  14. Jeff KingMay 9, 2016
  15. Junio C HamanoMay 9, 2016
  16. Junio C HamanoMay 9, 2016
  17. Eric SunshineMay 9, 2016
  18. Junio C HamanoMay 9, 2016
  19. Eric SunshineMay 9, 2016
  20. Jeff KingMay 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.