Re: [PATCH v5 3/6] builtin/verify-tag: change variable name for readability

From

Junio C Hamano <gitster@pobox.com>

Date

Apr 6, 2016, 16:46 UTC

Message-ID

<xmqqfuuyy9a5.fsf@gitster.mtv.corp.google.com>

In-Reply-To

<1459872449-7537-4-git-send-email-santiago@nyu.edu>

santiago@nyu.edu writes:

> From: Santiago Torres <santiago@nyu.edu>
>
> The run_gpg_verify function has two variables size, and len. 

I somehow found this harder to parse than necessary.

> This may come off as confusing when reading the code. We clarify which one
> pertains to the length of the tag headers by renaming len to
> payload_length.

I'd rephrase it like so:

    verify-tag: change variable name for readability

    The run_gpg_verify() function has two variables, size and len.
    This may come off as confusing when reading the code.

    Clarify which one pertains to the length of the tag headers by
    renaming len to payload_length.

The patch text looked good.