Re: [PATCH v5 2/6] t7030-verify-tag: Adds validation for multiple tags

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Apr 17, 2016, 18:19 UTC
Message-ID: <CAPig+cQYAAG7hVe6Li3-TZb99etkE22QzcWbKBCzr8L0SP5LXg@mail.gmail.com>
In-Reply-To: <20160417173155.GA1014@LykOS>

On Sun, Apr 17, 2016 at 1:31 PM, Santiago Torres <santiago@nyu.edu> wrote:

Show 14 quoted lines

>> +       grep "^.GNUPG" <expect.stderr.1 >expect.stderr &&
>>
>> Hmm, is there a reason you didn't stick with the more strict regex
>> Peff suggested?
>>
>>     ^.GNUPG:.
>>
>> (Genuine question: I'm not saying your choice is wrong, I'm just
>> interested in the reasoning behind the decision.)
>
> I actually had missed the ":". I read the email and tried to internalize
> what the new test was actually doing, then I rewrote the test.
>
> I think I could add it for completeness though.

Junio already made this correction and others in the three patches he queued on his 'pu' branch. It's possible that he also made other tweaks not mentioned in the reviews, so it's a good idea to compare what he queued against what you plan to send for the re-roll to ensure that nothing is missed. Thanks.