Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c
- From
Santiago Torres <santiago@nyu.edu>
- Date
- Apr 7, 2016, 03:40 UTC
- Message-ID
- <20160407034007.GC17848@LykOS>
- In-Reply-To
- <CAPig+cQ4n5j4Q-WF-0cd=2+5eSAaimh3A7La+8Fe9Ox4anjtBQ@mail.gmail.com>
Show 20 quoted lines
> > v5 (this): > > Added helpful feedback by Eric > > > > * Reordering of the patches, to avoid temporal inclusion of a regression > > * Fix typos here and there. > > * Review commit messages, as some weren't representative of what the patches > > were doing anymore. > > * Updated t7030 to include Peff's suggestion, and added a helped-by line here > > as it was mostly Peff's code. > > * Updated the error-handling/printing issues that were introduced when. > > libifying the verify_tag function. > > This version is a more pleasant read, easier to digest and understand. > All of my review comments were minor; nothing demanding a re-roll. As > such, this version is: > > Reviewed-by: Eric Sunshine <sunshine@sunshineco.com> > > If you do happen to re-roll based upon the review comments, feel free > to add my Reviewed-by: (but not if you make larger changes).
Thanks! I'll add your and Junio's in another re-roll. -Santiago.