Re: [PATCH v5 2/6] t7030-verify-tag: Adds validation for multiple tags

From: Santiago Torres <santiago@nyu.edu>
Date: Apr 17, 2016, 18:38 UTC
Message-ID: <20160417183815.GC1014@LykOS>
In-Reply-To: <CAPig+cQYAAG7hVe6Li3-TZb99etkE22QzcWbKBCzr8L0SP5LXg@mail.gmail.com>

On Sun, Apr 17, 2016 at 02:19:00PM -0400, Eric Sunshine wrote:

Show 21 quoted lines

> On Sun, Apr 17, 2016 at 1:31 PM, Santiago Torres <santiago@nyu.edu> wrote:
> >> +       grep "^.GNUPG" <expect.stderr.1 >expect.stderr &&
> >>
> >> Hmm, is there a reason you didn't stick with the more strict regex
> >> Peff suggested?
> >>
> >>     ^.GNUPG:.
> >>
> >> (Genuine question: I'm not saying your choice is wrong, I'm just
> >> interested in the reasoning behind the decision.)
> >
> > I actually had missed the ":". I read the email and tried to internalize
> > what the new test was actually doing, then I rewrote the test.
> >
> > I think I could add it for completeness though.
> 
> Junio already made this correction and others in the three patches he
> queued on his 'pu' branch. It's possible that he also made other
> tweaks not mentioned in the reviews, so it's a good idea to compare
> what he queued against what you plan to send for the re-roll to ensure
> that nothing is missed. Thanks.

Oh, I'm looking at the patches in pu, I didn't know they were there yet. Thanks for the heads up.

Also, would it make sense to copy the commit messages as they are on the pu branch? for consistency? Or should ommit those three patches and work on 4+ for the re-roll instead?