git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 0/6] tag: move PGP verification code to tag.c

From
Eric Sunshine <sunshine@sunshineco.com>
Date
Apr 6, 2016, 07:18 UTC
Message-ID
<CAPig+cQ4n5j4Q-WF-0cd=2+5eSAaimh3A7La+8Fe9Ox4anjtBQ@mail.gmail.com>
In-Reply-To
<1459872449-7537-1-git-send-email-santiago@nyu.edu>
On Tue, Apr 5, 2016 at 12:07 PM,  <santiago@nyu.edu> wrote:
Show 11 quoted lines
> v5 (this):
> Added helpful feedback by Eric
>
>  * Reordering of the patches, to avoid temporal inclusion of a regression
>  * Fix typos here and there.
>  * Review commit messages, as some weren't representative of what the patches
>    were doing anymore.
>  * Updated t7030 to include Peff's suggestion, and added a helped-by line here
>    as it was mostly Peff's code.
>  * Updated the error-handling/printing issues that were introduced when.
>    libifying the verify_tag function.

This version is a more pleasant read, easier to digest and understand. All of my review comments were minor; nothing demanding a re-roll. As such, this version is:

    Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>

If you do happen to re-roll based upon the review comments, feel free to add my Reviewed-by: (but not if you make larger changes).

Thanks.
Previous: Santiago TorresNext: Santiago Torres
Message 22 of 28 in “tag: move PGP verification code to tag.c”
  1. 0/6 tag: move PGP verification code to tag.csantiago@nyu.edu, Apr 5, 2016
  2. 1/6 builtin/verify-tag.c: Ignore SIGPIPE on gpg-interfacesantiago@nyu.edu, Apr 5, 2016
  3. Junio C HamanoApr 6, 2016
  4. 2/6 t7030-verify-tag: Adds validation for multiple tagssantiago@nyu.edu, Apr 5, 2016
  5. Eric SunshineApr 6, 2016
  6. Santiago TorresApr 17, 2016
  7. Eric SunshineApr 17, 2016
  8. Santiago TorresApr 17, 2016
  9. Eric SunshineApr 17, 2016
  10. Junio C HamanoApr 6, 2016
  11. 3/6 builtin/verify-tag: change variable name for readabilitysantiago@nyu.edu, Apr 5, 2016
  12. Junio C HamanoApr 6, 2016
  13. 4/6 builtin/verify-tag: replace name argument with sha1santiago@nyu.edu, Apr 5, 2016
  14. Eric SunshineApr 6, 2016
  15. Junio C HamanoApr 6, 2016
  16. Santiago TorresApr 7, 2016
  17. 5/6 builtin/verify-tag: move verification code to tag.csantiago@nyu.edu, Apr 5, 2016
  18. Junio C HamanoApr 6, 2016
  19. 6/6 tag: use gpg_verify_function in tag -v callsantiago@nyu.edu, Apr 5, 2016
  20. Eric SunshineApr 6, 2016
  21. Santiago TorresApr 5, 2016
  22. Eric SunshineApr 6, 2016
  23. Santiago TorresApr 7, 2016
  24. Eric SunshineApr 7, 2016
  25. Santiago TorresApr 17, 2016
  26. Eric SunshineApr 17, 2016
  27. Junio C HamanoApr 6, 2016
  28. Santiago TorresApr 7, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.