Re: [PATCH] t4014: shell portability fix

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 1, 2016, 16:57 UTC
Message-ID: <xmqqfuswzw2l.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160601160735.GB9219@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> Maybe:
>
>     We sometimes get around this by using env, like:
>
>       test_must_fail env FOO=BAR some-program
>
>     But that works for test_must_fail because it further runs its
>     arguments via the shell, so we can stick the "env" on the right-hand
>     side of the function. It would not work to do:
>
>       env FOO=BAR test_must_fail some-program
>
>     because env does not know about our shell functions...
>
> is more clear?

I don't know. What I wanted to say was that "test_must_fail env" pattern works _only_ when some-program is not a shell function, even though "test_must_fail some-program" itself without env is OK when some-program is a shell function.