Re: [PATCH] t4014: shell portability fix

From: Eric Sunshine <sunshine@sunshineco.com>
Date: Jun 1, 2016, 06:39 UTC
Message-ID: <CAPig+cRTnbjN2S5RLyPaNDdUT6pTig4==JbMUgVtaBKcaWy52g@mail.gmail.com>
In-Reply-To: <20160601023159.GA5411@sigill.intra.peff.net>

On Tue, May 31, 2016 at 10:31 PM, Jeff King <peff@peff.net> wrote:

Show 13 quoted lines

> On Tue, May 31, 2016 at 08:09:43PM -0400, Eric Sunshine wrote:
>> I was under the impression that the project was moving toward 'env' to
>> deal[1] with this sort of issue.
>>
>> [1]: 512477b (tests: use "env" to run commands with temporary env-var
>> settings, 2014-03-18)
>
> We can use it with test_must_fail, because it takes a command name:
>
>   test_must_fail env FOO=BAR whatever-you-would-have-run
>
> But I don't think it works in the general case, as test_commit does not
> run its arguments. [...]

You're right, of course. I should have seen this.